fix: env variable version resolution to match legacy behavior#2139
Closed
imranismail wants to merge 1 commit intoasdf-vm:masterfrom
Closed
fix: env variable version resolution to match legacy behavior#2139imranismail wants to merge 1 commit intoasdf-vm:masterfrom
imranismail wants to merge 1 commit intoasdf-vm:masterfrom
Conversation
imranismail
changed the title
Member
|
Thanks for the PR @imranismail and sorry for the extremely late review! These same changes were merged from #2194 and will go out in the next patch release. Closing this PR as it is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We still use shell-lived tool session in our workflows, however when migrating to manually setting the behavior using env var, we noticed this issue.
This fix ensures the pattern matches the legacy shell behavior
asdf/lib/commands/command-export-shell-version.bash
Line 20 in 2114f1e